Refactor MCP server update tool to call Go function directly #14139
+562
−74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP server's
updatetool was spawninggh-awas a subprocess for each invocation. This refactoring replaces subprocess execution with direct function calls.Changes
New context-aware API: Added
UpdateWorkflowsWithExtensionCheckContext(ctx context.Context, output io.Writer, ...)that:io.Writerinstead ofos.StderrWithWriter helper functions: Created output-parameterized versions of internal helpers:
checkExtensionUpdateWithWriterUpdateActionsWithWriterUpdateWorkflowsWithWriterRunFixWithWriter/runFixCommandWithWritercreateUpdatePRWithWritershowUpdateSummaryWithWriterprocessWorkflowFileWithInfo(w io.Writer, ...)MCP server integration: Updated
mcp_server.goupdate tool handler to callUpdateWorkflowsWithExtensionCheckContextdirectly withbytes.Bufferfor output captureBackward compatibility: Existing public functions unchanged, delegate to new WithWriter versions using
os.StderrExample
Before:
After:
No global state introduced. All state passed through parameters for thread-safe concurrent usage.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.